Add detachable tabs feature to preferences

terminatorlib/config.py

@@ -118,7 +118,8 @@ DEFAULTS = {
             'case_sensitive'        : True,
             'invert_search'         : False,
             'link_single_click'     : False,
-            'title_at_bottom'       : False
+            'title_at_bottom'       : False,
+            'detachable_tabs'       : True,
         },
         'keybindings': {
             'zoom_in'          : '<Control>plus',

terminatorlib/notebook.py

@@ -191,7 +191,7 @@ class Notebook(Container, Gtk.Notebook):
             sibling.force_set_profile(None, widget.get_profile())
 
         self.insert_page(container, None, page_num)
-        self.set_tab_detachable(container, True)
+        self.set_tab_detachable(container, self.config['detachable_tabs'])
         self.child_set_property(container, 'tab-expand', True)
         self.child_set_property(container, 'tab-fill', True)
         self.set_tab_reorderable(container, True)
@@ -320,7 +320,7 @@ class Notebook(Container, Gtk.Notebook):
 
         dbg('inserting page at position: %s' % tabpos)
         self.insert_page(widget, None, tabpos)
-        self.set_tab_detachable(widget, True)
+        self.set_tab_detachable(widget, self.config['detachable_tabs'])
 
         if maker.isinstance(widget, 'Terminal'):
             containers, objects = ([], [widget])

terminatorlib/preferences.glade

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<!-- Generated with glade 3.38.2 -->
+<!-- Generated with glade 3.40.0 -->
 <interface>
   <requires lib="gtk+" version="3.10"/>
   <object class="GtkListStore" id="BackspaceKeyListStore">
@@ -413,7 +413,7 @@
                             <property name="spacing">36</property>
                             <property name="homogeneous">True</property>
                             <child>
-                              <!-- n-columns=2 n-rows=7 -->
+                              <!-- n-columns=2 n-rows=8 -->
                               <object class="GtkGrid" id="grid1">
                                 <property name="visible">True</property>
                                 <property name="can-focus">False</property>
@@ -553,6 +553,23 @@
                                     <property name="width">2</property>
                                   </packing>
                                 </child>
+                                <child>
+                                  <object class="GtkCheckButton" id="detachable_tabs">
+                                    <property name="label" translatable="yes">Detach tab into new window on drag (Require restart)</property>
+                                    <property name="use-action-appearance">False</property>
+                                    <property name="visible">True</property>
+                                    <property name="can-focus">True</property>
+                                    <property name="receives-default">False</property>
+                                    <property name="xalign">0.5</property>
+                                    <property name="draw-indicator">True</property>
+                                    <signal name="toggled" handler="on_detachable_tabs_toggled" swapped="no"/>
+                                  </object>
+                                  <packing>
+                                    <property name="left-attach">0</property>
+                                    <property name="top-attach">7</property>
+                                    <property name="width">2</property>
+                                  </packing>
+                                </child>
                               </object>
                               <packing>
                                 <property name="expand">True</property>
@@ -3721,12 +3738,12 @@
             </child>
             <child>
               <object class="GtkVBox" id="vbox124">
+                <property name="can-focus">False</property>
                 <child>
                   <object class="GtkEntry" id="keybindingsearchentry">
                     <property name="visible">True</property>
                     <property name="can-focus">True</property>
-                    <property name="has-focus">False</property>
+                    <property name="placeholder-text">filter keybindings</property>
-                    <property name="placeholder_text">filter keybindings</property>
                   </object>
                   <packing>
                     <property name="expand">False</property>
@@ -3794,6 +3811,11 @@
                       </object>
                     </child>
                   </object>
+                  <packing>
+                    <property name="expand">True</property>
+                    <property name="fill">True</property>
+                    <property name="position">1</property>
+                  </packing>
                 </child>
               </object>
               <packing>

terminatorlib/prefseditor.py

@@ -770,6 +770,10 @@ class PrefsEditor:
         else:
             widget.set_font_name(self.config['title_font'])
 
+        # Whether tabs can be detached into their own window by dragging from titlebar
+        widget = guiget('detachable_tabs')
+        widget.set_active(self.config['detachable_tabs'])
+
     def set_layout(self, layout_name):
         """Set a layout"""
         self.layouteditor.set_layout(layout_name)
@@ -1873,6 +1877,10 @@ class PrefsEditor:
         """Open the fine manual"""
         self.term.key_help()
 
+    def on_detachable_tabs_toggled(self, widget):
+        self.config['detachable_tabs'] = widget.get_active()
+        self.config.save()
+
 class LayoutEditor:
     profile_ids_to_profile = None
     profile_profile_to_ids = None