itdominator
/
Tab-Search-and-Manage
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Metadata (addons.json) issues with, or affecting, extension ID tabsSearch@itdominator.com #2

New Issue
Closed
opened 2018-10-01 02:56:20 +00:00 by grahamperrin · 14 comments
grahamperrin commented 2018-10-01 02:56:20 +00:00 (Migrated from github.com)
Copy Link

From my Waterfox addons.json, for the extension (currently named Tab Search and Manage) that I might have first installed a few months ago:

{"id":"tabsSearch@itdominator.com","icons":{"32":"https://addons.cdn.mozilla.net/user-media/addon_icons/902/902061-32.png?modified=1525569623","64":"https://addons.cdn.mozilla.net/user-media/addon_icons/902/902061-64.png?modified=1525569623"},"type":"extension","name":"Tab Search","version":"1.1.8","creator":{"name":"ITDominator","url":"https://addons.mozilla.org/en-GB/firefox/user/ITDominator/?src=api"},"description":"Search tabs and switch to them quickly! This plugin will will generate a list if there is more than one tab present for the query. Otherwise, it will select the tab that matches the search term given.","fullDescription":null,"developerComments":null,"eula":null,"screenshots":[{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/201/201343.png?src=api&modified=1525220405","width":"700","height":"524","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/201/201343.png?src=api&modified=1525220405","thumbnailWidth":"200","thumbnailHeight":"150","caption":"Shows all tabs before search."},{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/201/201344.png?src=api&modified=1525220405","width":"674","height":"525","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/201/201344.png?src=api&modified=1525220405","thumbnailWidth":"192","thumbnailHeight":"150","caption":"Tabs after search."},{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/201/201345.png?src=api&modified=1525220405","width":"700","height":"522","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/201/201345.png?src=api&modified=1525220405","thumbnailWidth":"200","thumbnailHeight":"149","caption":"Drag and drop tab management."}],"homepageURL":"https://www.itdominator.com/","learnmoreURL":"https://addons.mozilla.org/en-GB/firefox/addon/tab-search-smarter/?src=api","supportURL":"https://github.com/maximstewart/Tab-Search-Firefox","averageRating":0,"reviewCount":0,"reviewURL":"https://addons.mozilla.org/en-GB/firefox/addon/tab-search-smarter/reviews/?src=api","totalDownloads":191,"weeklyDownloads":8,"dailyUsers":38,"repositoryStatus":4,"updateDate":1525568428000,"isPlatformCompatible":false}

The learnmoreURL and reviewURL values are wrong, probably outdated; https://addons.mozilla.org/addon/tab-search-smarter/ is not found.

I guess, the AMO tab-search-smarter slug was changed to tab-search-and-manage – @maximstewart, is that so?

Also:

As far as I can tell, I can not reproduce the wrongness with addition of the extension from https://addons.mozilla.org/addon/tab-search-and-manage/ to a new profile.

From my Waterfox `addons.json`, for the extension (currently named _Tab Search and Manage_) that I might have first installed a few months ago: `{"id":"tabsSearch@itdominator.com","icons":{"32":"https://addons.cdn.mozilla.net/user-media/addon_icons/902/902061-32.png?modified=1525569623","64":"https://addons.cdn.mozilla.net/user-media/addon_icons/902/902061-64.png?modified=1525569623"},"type":"extension","name":"Tab Search","version":"1.1.8","creator":{"name":"ITDominator","url":"https://addons.mozilla.org/en-GB/firefox/user/ITDominator/?src=api"},"description":"Search tabs and switch to them quickly! This plugin will will generate a list if there is more than one tab present for the query. Otherwise, it will select the tab that matches the search term given.","fullDescription":null,"developerComments":null,"eula":null,"screenshots":[{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/201/201343.png?src=api&modified=1525220405","width":"700","height":"524","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/201/201343.png?src=api&modified=1525220405","thumbnailWidth":"200","thumbnailHeight":"150","caption":"Shows all tabs before search."},{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/201/201344.png?src=api&modified=1525220405","width":"674","height":"525","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/201/201344.png?src=api&modified=1525220405","thumbnailWidth":"192","thumbnailHeight":"150","caption":"Tabs after search."},{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/201/201345.png?src=api&modified=1525220405","width":"700","height":"522","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/201/201345.png?src=api&modified=1525220405","thumbnailWidth":"200","thumbnailHeight":"149","caption":"Drag and drop tab management."}],"homepageURL":"https://www.itdominator.com/","learnmoreURL":"https://addons.mozilla.org/en-GB/firefox/addon/tab-search-smarter/?src=api","supportURL":"https://github.com/maximstewart/Tab-Search-Firefox","averageRating":0,"reviewCount":0,"reviewURL":"https://addons.mozilla.org/en-GB/firefox/addon/tab-search-smarter/reviews/?src=api","totalDownloads":191,"weeklyDownloads":8,"dailyUsers":38,"repositoryStatus":4,"updateDate":1525568428000,"isPlatformCompatible":false}` The `learnmoreURL` and `reviewURL` values are wrong, probably outdated; https://addons.mozilla.org/addon/tab-search-smarter/ is not found. I guess, the AMO `tab-search-smarter` slug was changed to `tab-search-and-manage` – @maximstewart, is that so? Also: - the version above (1.1.8) does not match the installed version (1.2.9) - there _was_ a version 1.1.8 at https://addons.mozilla.org/addon/tab-search-and-manage/versions/?page=1#version-1.1.8 that's listed as _Tab Search and Manage_ but I wonder whether the name was different at the time of 1.1.8 - `1.2.9` is nowhere in `addons.json`. As far as I can tell, I can not reproduce the wrongness with addition of the extension from https://addons.mozilla.org/addon/tab-search-and-manage/ to a new profile.
maximstewart commented 2018-10-01 03:12:27 +00:00 (Migrated from github.com)
Copy Link

"I guess, the AMO tab-search-smarter slug was changed to tab-search-and-manage – @maximstewart, is that so?"

This is correct as I wanted to make it clearer what the plugin could and couldn't do so did a name change.

"the version above (1.1.8) does not match the installed version (1.2.9)"

I at one point did an overhaul of the themeing and the name change was a part of that. I have another plugin that I'm working on that this plugin branched from. The other plugin is in limbo as the idea for it was/is for it to mimic Firefox's Tabgroups functionality. Other than that, I'm not certain what's different to you in 1.2.9?

https://addons.mozilla.org/en-US/firefox/addon/tab-groups-with-search-manager/

"As far as I can tell, I can not reproduce the wrongness with addition of the extension from"

I'm not sure what's wrong that you are referencing?

"I guess, the AMO tab-search-smarter slug was changed to tab-search-and-manage – @maximstewart, is that so?" This is correct as I wanted to make it clearer what the plugin could and couldn't do so did a name change. "the version above (1.1.8) does not match the installed version (1.2.9)" I at one point did an overhaul of the themeing and the name change was a part of that. I have another plugin that I'm working on that this plugin branched from. The other plugin is in limbo as the idea for it was/is for it to mimic Firefox's Tabgroups functionality. Other than that, I'm not certain what's different to you in 1.2.9? https://addons.mozilla.org/en-US/firefox/addon/tab-groups-with-search-manager/ "As far as I can tell, I can not reproduce the wrongness with addition of the extension from" I'm not sure what's wrong that you are referencing?
grahamperrin commented 2018-10-01 06:59:18 +00:00 (Migrated from github.com)
Copy Link

Thanks, I saw the other extension.

I'm not sure what's wrong that you are referencing?

The wrongness is within the addons.json in the affected Waterfox profile.

Maybe best described as staleness. It surprises me that I can remove the extension, quit Waterfox, start Waterfox, add the extension then (behind the scenes) not find proper information in addons.json.

Without looking behind the scenes, the problem was first observed when I used Add-ons Manager Context Menu to open the AMO page for the installed extension. Still observable (screen recording to follow) …

I guess, I might work around by again removing the extension, quitting Waterfox and then manually editing out the wrong part of the file. Do-able, but extraordinary.

Thanks, I saw the other extension. > I'm not sure what's wrong that you are referencing? The wrongness is within the `addons.json` in the affected Waterfox profile. Maybe best described as _staleness_. It surprises me that I can remove the extension, quit Waterfox, start Waterfox, add the extension then (behind the scenes) **not** find proper information in `addons.json`. Without looking behind the scenes, the problem was first observed when I used [Add-ons Manager Context Menu](https://addons.mozilla.org/addon/am-context/) to open the AMO page for the installed extension. Still observable (screen recording to follow) … - I guess, I _might_ work around by again removing the extension, quitting Waterfox and then manually editing out the wrong part of the file. Do-able, but extraordinary.
maximstewart commented 2018-10-02 01:48:52 +00:00 (Migrated from github.com)
Copy Link

"Waterfox, add the extension then (behind the scenes) not find proper information in addons.json."

XD I'm deff gunna need to see a vid of this as I'm still not clear on what's stale.

You had said before this: "The learnmoreURL and reviewURL values are wrong, probably outdated..."
Is this the staleness you speak of?

"Waterfox, add the extension then (behind the scenes) not find proper information in addons.json." XD I'm deff gunna need to see a vid of this as I'm still not clear on what's stale. You had said before this: "The learnmoreURL and reviewURL values are wrong, probably outdated..." Is this the staleness you speak of?
grahamperrin commented 2018-10-02 06:31:34 +00:00 (Migrated from github.com)
Copy Link

Thanks … I need to make a new screen recording.

(The recording that I made yesterday was confused by the Remove button not working in one context at about:addons.)

Thanks … I need to make a new screen recording. (The recording that I made yesterday was confused by the Remove button not working in one context at `about:addons`.)
maximstewart commented 2018-10-03 03:25:10 +00:00 (Migrated from github.com)
Copy Link

Sounds good. =]

Sounds good. =]
grahamperrin commented 2018-10-03 06:29:11 +00:00 (Migrated from github.com)
Copy Link

Recording: https://photos.app.goo.gl/iZ1Tm1sJzNyKZAs46

Recording: https://photos.app.goo.gl/iZ1Tm1sJzNyKZAs46
maximstewart commented 2018-10-05 05:19:45 +00:00 (Migrated from github.com)
Copy Link

Hey, OK, I got a chance to look at your video and see what you mean. I'm not sure why it's not showing incorrectly your end as I looked at my addons.js file and it shows the proper name and version number.

Here's my video.
Uploading 2018-10-05 00-14-52.mkv.zip…

Hey, OK, I got a chance to look at your video and see what you mean. I'm not sure why it's not showing incorrectly your end as I looked at my addons.js file and it shows the proper name and version number. Here's my video. [Uploading 2018-10-05 00-14-52.mkv.zip…]()
grahamperrin commented 2018-10-06 02:28:27 +00:00 (Migrated from github.com)
Copy Link

Uploading 2018-10-05 00-14-52.mkv.zip…

I can't view the video :-) but I'm sure that it's fine for you.

I imagine that the issue might be reproducible if begun with an installation of outdated 1.1.8 but it's probably not worth troubleshooting.

Instead, I'll try a manual edition of addons.js

> Uploading 2018-10-05 00-14-52.mkv.zip… I can't view the video :-) but I'm sure that it's fine for you. I _imagine_ that the issue might be reproducible if begun with an installation of outdated 1.1.8 but it's probably not worth troubleshooting. Instead, I'll try a manual edition of `addons.js`
maximstewart commented 2018-10-06 04:08:15 +00:00 (Migrated from github.com)
Copy Link

The video is zipped and is an mkv. Ummm, OK, if you want to do the edit then good luck! I'll close this bug then.

The video is zipped and is an mkv. Ummm, OK, if you want to do the edit then good luck! I'll close this bug then.
grahamperrin commented 2018-10-06 10:56:40 +00:00 (Migrated from github.com)
Copy Link

Thanks, incidentally it appears that your previous comment was submitted before upload of the .zip completed …

Thanks, incidentally it appears that your previous comment was submitted before upload of the `.zip` completed …
maximstewart commented 2018-10-06 15:24:15 +00:00 (Migrated from github.com)
Copy Link

Hmmm, let me try again?

2018-10-05 00-14-52.mkv.zip

Hmmm, let me try again? [2018-10-05 00-14-52.mkv.zip](https://github.com/maximstewart/Tab-Search-Firefox/files/2453133/2018-10-05.00-14-52.mkv.zip)
grahamperrin commented 2018-10-08 05:36:39 +00:00 (Migrated from github.com)
Copy Link

OK, I quit Waterfox, removed the troublesome part from addons.json then started Waterfox and added outdated version 1.2.8.

Result

At the tail of the file, this, with 1.2.9 (not 1.2.8):

{"id":"tabsSearch@itdominator.com","icons":{"32":"https://addons.cdn.mozilla.net/user-media/addon_icons/902/902061-32.png?modified=1527200423","64":"https://addons.cdn.mozilla.net/user-media/addon_icons/902/902061-64.png?modified=1527200423"},"name":"Tab Search and Manage","type":"extension","version":"1.2.9","repositoryStatus":4,"creator":{"name":"ITDominator","url":"https://addons.mozilla.org/en-GB/firefox/user/ITDominator/?src=api"},"description":"This plugin can search, drag-n-drop ordering, and (un)hide all or some tabs. A search redirects automatically if the search is found and is a single instance. Search multiple windows by toggling the window icon on the bottom.","fullDescription":null,"isPlatformCompatible":true,"eula":null,"screenshots":[{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/202/202748.png?src=api&modified=1530209521","width":"762","height":"576","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/202/202748.png?src=api&modified=1530209521","thumbnailWidth":"265","thumbnailHeight":"200","caption":"Default list style without interacting with tab."},{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/202/202749.png?src=api&modified=1530209522","width":"760","height":"572","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/202/202749.png?src=api&modified=1530209522","thumbnailWidth":"266","thumbnailHeight":"200","caption":"Hovering on tab."},{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/202/202750.png?src=api&modified=1530209524","width":"761","height":"572","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/202/202750.png?src=api&modified=1530209524","thumbnailWidth":"266","thumbnailHeight":"200","caption":"List of tabs matching search."},{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/202/202751.png?src=api&modified=1530209526","width":"1280","height":"454","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/202/202751.png?src=api&modified=1530209526","thumbnailWidth":"320","thumbnailHeight":"114","caption":"3 tabs hidden and three shown."},{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/202/202752.png?src=api&modified=1530209528","width":"1280","height":"456","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/202/202752.png?src=api&modified=1530209528","thumbnailWidth":"320","thumbnailHeight":"114","caption":"All tabs but current active hidden."},{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/202/202753.png?src=api&modified=1530209529","width":"759","height":"255","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/202/202753.png?src=api&modified=1530209529","thumbnailWidth":"320","thumbnailHeight":"108","caption":"Search failed response."}],"averageRating":4,"learnmoreURL":"https://addons.mozilla.org/en-GB/firefox/addon/tab-search-and-manage/?src=api","homepageURL":"https://www.itdominator.com/","sourceURI":"https://addons.mozilla.org/firefox/downloads/file/1093800/tab_search_and_manage-1.2.9-fx.xpi?src=api","size":64617,"developerComments":null,"reviewURL":"https://addons.mozilla.org/en-GB/firefox/addon/tab-search-and-manage/reviews/?src=api","reviewCount":2,"totalDownloads":358,"weeklyDownloads":22,"dailyUsers":35,"updateDate":1538345407000,"supportURL":"https://github.com/maximstewart/Tab-Search-Firefox"}]}

– properly represented as 1.2.8 at about:addons

2018-10-08 06 33 59 add-ons manager

– and a manual check for updates finds the update from 1.2.8 to 1.2.9:

2018-10-08 06 34 23 add-ons manager

OK, I quit Waterfox, removed the troublesome part from `addons.json` then started Waterfox and added outdated version 1.2.**8**. ### Result At the tail of the file, this, with 1.2.**9** (not 1.2.8): `{"id":"tabsSearch@itdominator.com","icons":{"32":"https://addons.cdn.mozilla.net/user-media/addon_icons/902/902061-32.png?modified=1527200423","64":"https://addons.cdn.mozilla.net/user-media/addon_icons/902/902061-64.png?modified=1527200423"},"name":"Tab Search and Manage","type":"extension","version":"1.2.9","repositoryStatus":4,"creator":{"name":"ITDominator","url":"https://addons.mozilla.org/en-GB/firefox/user/ITDominator/?src=api"},"description":"This plugin can search, drag-n-drop ordering, and (un)hide all or some tabs. A search redirects automatically if the search is found and is a single instance. Search multiple windows by toggling the window icon on the bottom.","fullDescription":null,"isPlatformCompatible":true,"eula":null,"screenshots":[{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/202/202748.png?src=api&modified=1530209521","width":"762","height":"576","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/202/202748.png?src=api&modified=1530209521","thumbnailWidth":"265","thumbnailHeight":"200","caption":"Default list style without interacting with tab."},{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/202/202749.png?src=api&modified=1530209522","width":"760","height":"572","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/202/202749.png?src=api&modified=1530209522","thumbnailWidth":"266","thumbnailHeight":"200","caption":"Hovering on tab."},{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/202/202750.png?src=api&modified=1530209524","width":"761","height":"572","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/202/202750.png?src=api&modified=1530209524","thumbnailWidth":"266","thumbnailHeight":"200","caption":"List of tabs matching search."},{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/202/202751.png?src=api&modified=1530209526","width":"1280","height":"454","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/202/202751.png?src=api&modified=1530209526","thumbnailWidth":"320","thumbnailHeight":"114","caption":"3 tabs hidden and three shown."},{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/202/202752.png?src=api&modified=1530209528","width":"1280","height":"456","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/202/202752.png?src=api&modified=1530209528","thumbnailWidth":"320","thumbnailHeight":"114","caption":"All tabs but current active hidden."},{"url":"https://addons.cdn.mozilla.net/user-media/previews/full/202/202753.png?src=api&modified=1530209529","width":"759","height":"255","thumbnailURL":"https://addons.cdn.mozilla.net/user-media/previews/thumbs/202/202753.png?src=api&modified=1530209529","thumbnailWidth":"320","thumbnailHeight":"108","caption":"Search failed response."}],"averageRating":4,"learnmoreURL":"https://addons.mozilla.org/en-GB/firefox/addon/tab-search-and-manage/?src=api","homepageURL":"https://www.itdominator.com/","sourceURI":"https://addons.mozilla.org/firefox/downloads/file/1093800/tab_search_and_manage-1.2.9-fx.xpi?src=api","size":64617,"developerComments":null,"reviewURL":"https://addons.mozilla.org/en-GB/firefox/addon/tab-search-and-manage/reviews/?src=api","reviewCount":2,"totalDownloads":358,"weeklyDownloads":22,"dailyUsers":35,"updateDate":1538345407000,"supportURL":"https://github.com/maximstewart/Tab-Search-Firefox"}]}` – properly represented as 1.2.8 at about:addons ![2018-10-08 06 33 59 add-ons manager](https://user-images.githubusercontent.com/192271/46593494-5bf53f00-cac4-11e8-990a-93e2ab52a676.png) – and a manual check for updates finds the update from 1.2.8 to 1.2.9: ![2018-10-08 06 34 23 add-ons manager](https://user-images.githubusercontent.com/192271/46593509-77604a00-cac4-11e8-8c59-fda5a2359871.png)
grahamperrin commented 2018-10-09 01:50:32 +00:00 (Migrated from github.com)
Copy Link

I stumbled across comparable symptoms affecting a different extension, in Firefox, so I raised this:

I stumbled across comparable symptoms affecting a different extension, in Firefox, so I raised this: - Mozilla bug [1497387 - Outdated, stale extensions metadata in addons.json](https://bugzilla.mozilla.org/show_bug.cgi?id=1497387)
maximstewart commented 2018-10-09 02:02:12 +00:00 (Migrated from github.com)
Copy Link

Ahhh, OK, sounds good!!

Ahhh, OK, sounds good!!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
good first issue

   
help wanted

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: itdominator/Tab-Search-and-Manage#2
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?