Find-as-you-type (FAYT) reset with, or after, a space

grahamperrin commented

2018-09-26 20:25:13 +00:00

(Migrated from github.com)

Visit https://addons.mozilla.org/addon/tab-search-and-manage/
add the extension
open a new window
click the button for the extension
switch to multi-window mode
dismiss the dialogue
click the button for the extension
type:

tabSpace bar

Expected

Ability to seek a multi-word string

Actual results

With Waterfox 56.2.3, as far as I can tell the search field is reset (cleared) with the first key press after Space bar.

With Firefox 62.0, the search field is reset when Space bar is keyed.

1. Visit https://addons.mozilla.org/addon/tab-search-and-manage/ 2. add the extension 5. open a new window 4. click the button for the extension 5. switch to multi-window mode 6. dismiss the dialogue 7. click the button for the extension 8. type: <kbd>t</kbd><kbd>a</kbd><kbd>b</kbd><kbd>Space bar</kbd> ### Expected Ability to seek a multi-word string ### Actual results With Waterfox 56.2.3, as far as I can tell the search field is reset (cleared) with the first key press _after_ <kbd>Space bar</kbd>. With Firefox 62.0, the search field is reset when <kbd>Space bar</kbd> is keyed.

maximstewart commented

2018-09-27 02:41:01 +00:00

(Migrated from github.com)

Hi, thank you for taking the time to help me improve the plugin by reporting your issue! I have a few questions to try and get to the bottom of this.

First, are you a Windows, Mac, or Linux user?
With the second window, is it under the first window, next to it, or minimized?
If on Linux, is the second window on a different virtual desktop?

Since the search is resetting, that means the plugin has found what you are looking for and there is a single instance of it. So, it's trying to select the new window. I should preface this by say that as far as I am aware, window selection is handled by the desktop and the browser makes a call to it for it to manage the action. I might be limited to what I can fix or do for guidance. I know on Linux Firefox doesn't seem to actually redirect the display to the virtual one it's on if a call is made to it. Otherwise, everything I asked above works. I haven't gotten to test fully on Windows since I don't use it that often and I haven't tried Mac.

Hi, thank you for taking the time to help me improve the plugin by reporting your issue! I have a few questions to try and get to the bottom of this. First, are you a Windows, Mac, or Linux user? With the second window, is it under the first window, next to it, or minimized? If on Linux, is the second window on a different virtual desktop? Since the search is resetting, that means the plugin has found what you are looking for and there is a single instance of it. So, it's trying to select the new window. I should preface this by say that as far as I am aware, window selection is handled by the desktop and the browser makes a call to it for it to manage the action. I might be limited to what I can fix or do for guidance. I know on Linux Firefox doesn't seem to actually redirect the display to the virtual one it's on if a call is made to it. Otherwise, everything I asked above works. I haven't gotten to test fully on Windows since I don't use it that often and I haven't tried Mac.

grahamperrin commented

2018-09-30 17:39:26 +00:00

(Migrated from github.com)

FreeBSD-CURRENT here. For an issue such as this, it's reasonable to treat Firefox (and Waterfox) on FreeBSD as you would treat them on Linux.

Here's a screen recording of the extension with Firefox 62.0.2. In the second half of the recording there is (I think) strange behaviour when typing part of the word review

2018-09-30 18:16.zip

… Since the search is resetting, that means the plugin has found what you are looking for and there is a single instance of it. …

It 'feels' strange that the word disappears before I can finish typing …

FreeBSD-CURRENT here. For an issue such as this, it's reasonable to treat Firefox (and Waterfox) on FreeBSD as you would treat them on Linux. Here's a screen recording of the extension with Firefox 62.0.2. In the second half of the recording there is (I think) strange behaviour when typing part of the word _review_ [2018-09-30 18:16.zip](https://github.com/maximstewart/Tab-Search-Firefox/files/2431798/2018-09-30.18.16.zip) > … Since the search is resetting, that means the plugin has found what you are looking for and there is a single instance of it. … It 'feels' strange that the word disappears before I can finish typing …

maximstewart commented

2018-09-30 18:06:04 +00:00

(Migrated from github.com)

Hmmm, OK, looking over the video everything looks like it's working as it should up until a new window is opened. As a quick side note, when you type "itdominator" fully at 19 seconds in, it does seem to miss one of the tabs since there are actually three. But, even though it's missing one it does show the two you can select. By the way, when doing a search, if more than one tab is found, you can look through those that are found and click in the plugin window to select the tab.

As an update, I tried what you did and get the same results. After observing, it looks like the window isn't being selected after search is complete. I think I know a fix for this.

Hmmm, OK, looking over the video everything looks like it's working as it should up until a new window is opened. As a quick side note, when you type "itdominator" fully at 19 seconds in, it does seem to miss one of the tabs since there are actually three. But, even though it's missing one it does show the two you can select. By the way, when doing a search, if more than one tab is found, you can look through those that are found and click in the plugin window to select the tab. As an update, I tried what you did and get the same results. After observing, it looks like the window isn't being selected after search is complete. I think I know a fix for this.

maximstewart commented

2018-09-30 22:13:15 +00:00

(Migrated from github.com)

I believe this is resolved after I made some changes. Please test and advise after updating the plugin.

👍 1

grahamperrin commented

2018-10-01 02:33:25 +00:00

(Migrated from github.com)

Thanks! At a glance, the windowing issue is fixed.

From a usability perspective, the reset – more specifically – the disappearance of the UI – feels strange. Particularly if before a search there was focus in a form field in the found window. Like, I might seek

Babcock

– and end up with the word cock in a field and not notice the unexpected entry.

Thanks! At a glance, the windowing issue is fixed. From a usability perspective, the reset – more specifically – the disappearance of the UI – feels strange. Particularly if _before a search_ there was focus in a form field in the found window. Like, I might seek `Babcock` – and end up with the word `cock` in a field **and** not notice the unexpected entry.

maximstewart commented

2018-10-01 02:54:01 +00:00

(Migrated from github.com)

Hmmmm, I'm sorry but I'm not following? Would you make screen cap to show what you mean? From what I understand, you are talking about the plugin window disappearing after a match that is single is found, correct? So, you find the plugin window disappearing awkward? If this is correct, then there isn't a thing I can do since the plugin window is losing focus and it fires an event to hide itself. This is part of Firefox than the actual plugin.

grahamperrin commented

2018-10-24 03:26:44 +00:00

(Migrated from github.com)

https://addons.mozilla.org/en-GB/firefox/addon/tab-search-and-manage/reviews/1217411/

… would you please update your ranking of this plugin based on the new version?

Done 👍 thanks for the nudge.

Also it's in a shortlist of suggested extensions. When I find the list, I'll add a note here.

https://addons.mozilla.org/en-GB/firefox/addon/tab-search-and-manage/reviews/1217411/ > … would you please update your ranking of this plugin based on the new version? Done :+1: thanks for the nudge. Also it's in a shortlist of suggested extensions. When I find the list, I'll add a note here.

Find-as-you-type (FAYT) reset with, or after, a space #1

Expected

Actual results