feat: Complete plugin lifecycle management with lazy loading and runtime reload
Major changes: - Add unload() method to all plugins for proper cleanup (unregister commands/providers/LSP clients, destroy widgets, clear state) - Implement lazy widget loading via "show" signal across all containers - Add autoload: false manifest option for manual/conditional plugin loading - Add Plugins UI with runtime load/unload toggle via Ctrl+Shift+p - Implement controller unregistration system with proper signal disconnection - Add new events: UnregisterCommandEvent, GetFilesEvent, GetSourceViewsEvent, TogglePluginsUiEvent - Fix signal leaks by tracking and disconnecting handlers in widgets (search/replace, LSP manager, tabs, telescope, markdown preview) - Add Save/Save As to tabs context menu - Improve search/replace behavior (selection handling, focus management) - Add telescope file initialization from existing loaded files - Refactor plugin reload watcher to dynamically add/remove plugins on filesystem changes - Add new plugins: file_history, extend_source_view_menu, godot_lsp_client - Fix bug in prettify_json (undefined variable reference)
This commit is contained in:
@@ -115,9 +115,9 @@ class ListBox(Gtk.ListBox):
|
||||
|
||||
self.select_row(next_row)
|
||||
|
||||
def add_row(self, event):
|
||||
label = Gtk.Label(label = event.file.fname)
|
||||
label.file = event.file
|
||||
def add_row(self, file):
|
||||
label = Gtk.Label(label = file.fname)
|
||||
label.file = file
|
||||
label.show()
|
||||
self.add(label)
|
||||
|
||||
|
||||
@@ -25,7 +25,7 @@ class Plugin(PluginCode):
|
||||
if isinstance(event, Code_Event_Types.FocusedViewEvent):
|
||||
...
|
||||
elif isinstance(event, Code_Event_Types.AddedNewFileEvent):
|
||||
telescope.list_box.add_row(event)
|
||||
telescope.list_box.add_row(event.file)
|
||||
elif isinstance(event, Code_Event_Types.RemovedFileEvent):
|
||||
telescope.list_box.remove_row(event)
|
||||
elif isinstance(event, Code_Event_Types.FilePathSetEvent):
|
||||
@@ -46,7 +46,7 @@ class Plugin(PluginCode):
|
||||
)
|
||||
self.emit_to("source_views", event)
|
||||
|
||||
event = Event_Factory.create_event(
|
||||
event = Event_Factory.create_event(
|
||||
"create_source_view",
|
||||
state = SourceViewStates.INDEPENDENT
|
||||
)
|
||||
@@ -55,12 +55,38 @@ class Plugin(PluginCode):
|
||||
source_view = event.response
|
||||
telescope.set_source_view(source_view)
|
||||
|
||||
event = Event_Factory.create_event(
|
||||
event = Event_Factory.create_event(
|
||||
"register_completer",
|
||||
completer = source_view.get_completion()
|
||||
)
|
||||
self.emit_to("completion", event)
|
||||
|
||||
event = Event_Factory.create_event("get_files")
|
||||
self.emit_to("files", event)
|
||||
for file in event.response:
|
||||
telescope.list_box.add_row(file)
|
||||
|
||||
def unload(self):
|
||||
window = self.request_ui_element("main-window")
|
||||
|
||||
telescope.unmap_parent_resize_event(window)
|
||||
|
||||
event = Event_Factory.create_event("unregister_command",
|
||||
command_name = "telescope",
|
||||
command = Handler,
|
||||
binding_mode = "released",
|
||||
binding = "<Control>b"
|
||||
)
|
||||
self.emit_to("source_views", event)
|
||||
|
||||
event = Event_Factory.create_event(
|
||||
"unregister_completer",
|
||||
completer = telescope.source_view.get_completion()
|
||||
)
|
||||
self.emit_to("completion", event)
|
||||
|
||||
telescope.destroy()
|
||||
|
||||
|
||||
def run(self):
|
||||
...
|
||||
|
||||
@@ -33,6 +33,7 @@ class Telescope(Gtk.Dialog):
|
||||
def _setup_signals(self):
|
||||
self.connect("focus-out-event", self._focus_out_event)
|
||||
self.connect("show", self._show)
|
||||
self.connect("destroy", self._handle_destroy)
|
||||
|
||||
def _subscribe_to_events(self):
|
||||
...
|
||||
@@ -93,7 +94,10 @@ class Telescope(Gtk.Dialog):
|
||||
self.source_view.set_buffer(buffer)
|
||||
|
||||
def map_parent_resize_event(self, parent):
|
||||
parent.connect("size-allocate", lambda w, r: self._map_resize(self, parent))
|
||||
self.size_allocate_id = parent.connect("size-allocate", lambda w, r: self._map_resize(self, parent))
|
||||
|
||||
def unmap_parent_resize_event(self, parent):
|
||||
parent.disconnect(self.size_allocate_id)
|
||||
|
||||
def set_source_view(self, source_view):
|
||||
scrolled_win = Gtk.ScrolledWindow()
|
||||
@@ -103,3 +107,8 @@ class Telescope(Gtk.Dialog):
|
||||
self.main_box.pack_end(scrolled_win, True, True, 0)
|
||||
|
||||
scrolled_win.show_all()
|
||||
|
||||
def _handle_destroy(self, widget):
|
||||
self.disconnect_by_func(self._focus_out_event)
|
||||
self.disconnect_by_func(self._show)
|
||||
self.disconnect_by_func(self._handle_destroy)
|
||||
|
||||
Reference in New Issue
Block a user