Refactor file loading to detect external modifications and add reload capability

- Extract _load_data() method from load_path() for reuse in reload()
- Add is_extters externally_modified() to track file state changes (mtime/size)
- Replace load_bytes() with load_contents() for better error handling
- Add reload() method to re-read file from disk
- Fix file_state_watcher by properly detecting external changes
- Update TODO list (add Terminal plugin, mark file_state_watcher as fixed)
This commit is contained in:
2026-03-22 00:35:11 -05:00
parent ec69d4db73
commit 13908d7ba7
4 changed files with 44 additions and 24 deletions

View File

@@ -3,6 +3,7 @@ ___
1. Add Godot LSP Client
1. Add TreeSitter
1. Add Collapsable code blocks
1. Add Terminal plugin
1. Add Plugin to <Shift\><Ctrl\>| and <Ctrl\>| to split views up, down, left, right
1. Add <Ctrl\>i to **lsp_manager** to list who implements xyz
@@ -13,7 +14,6 @@ ___
___
### Fix
- Fix **file_state_watcher** to prompt refrsh if external changes applied
- Fix on lsp client unload to close files lsp side and unload server endpoint
- Fix multi-select <Shift\><Ctrl\> left/right block select movement de-sync
from leader when '_' in word

View File

@@ -13,8 +13,6 @@ from gi.repository import Gtk
def add_prettify_json(buffer, menu):
menu.append(separator)
def on_prettify_json(menuitem, buffer):
start_itr, \
end_itr = buffer.get_start_iter(), buffer.get_end_iter()

View File

@@ -120,21 +120,7 @@ class SourceFile(GtkSource.File):
return gfile
def load_path(self, gfile: Gio.File):
if not gfile: return
text = gfile.load_bytes()[0].get_data().decode("UTF-8")
info = gfile.query_info('standard::content-type', Gio.FileQueryInfoFlags.NONE, None)
content_type = info.get_content_type()
self.ftype = Gio.content_type_get_mime_type(content_type) \
.replace("application/", "") \
.replace("text/", "") \
.replace("x-", "")
self.set_path(gfile)
logger.debug(f"File content type: {self.ftype}")
def _load_data(self, text: str, is_new: bool = True):
undo_manager = self.buffer.get_undo_manager()
self.buffer.block_changed_signal()
@@ -151,11 +137,13 @@ class SourceFile(GtkSource.File):
self.buffer.delete(start_itr, end_itr)
self.buffer.insert(start_itr, text, -1)
self.is_externally_modified()
GLib.idle_add(move_insert_to_start)
undo_manager.end_not_undoable_action()
self.buffer.set_modified(False)
if is_new:
eve = Event_Factory.create_event(
"loaded_new_file",
file = self
@@ -166,6 +154,32 @@ class SourceFile(GtkSource.File):
self.buffer.unblock_changed_after_signal()
self.buffer.unblock_modified_changed_signal()
def is_externally_modified(self) -> bool:
stat = os.stat(self.fpath)
current = (stat.st_mtime_ns, stat.st_size)
is_modified = \
hasattr(self, "last_state") and not current == self.last_state
self.last_state = current
return is_modified
def load_path(self, gfile: Gio.File):
if not gfile: return
loaded, contents, etag_out = gfile.load_contents()
if not loaded: raise Exception("File couldn't be loaded...'")
text = contents.decode("UTF-8")
info = gfile.query_info('standard::content-type', Gio.FileQueryInfoFlags.NONE, None)
content_type = info.get_content_type()
self.ftype = Gio.content_type_get_mime_type(content_type) \
.replace("application/", "") \
.replace("text/", "") \
.replace("x-", "")
self.set_path(gfile)
logger.debug(f"File content type: {self.ftype}")
self._load_data(text)
def set_path(self, gfile: Gio.File):
if not gfile: return
@@ -177,9 +191,17 @@ class SourceFile(GtkSource.File):
event = Event_Factory.create_event("file_path_set", file = self)
self.emit(event)
def reload(self):
loaded, contents, etag_out = self.get_location().load_contents()
if not loaded: raise Exception("File couldn't be re-loaded...'")
text = contents.decode("UTF-8")
self._load_data(text, False)
def save(self):
self._write_file( self.get_location() )
self.is_externally_modified()
self.buffer.set_modified(False)
event = Event_Factory.create_event(
"saved_file",

Binary file not shown.