itdominator
/
Easy-Session-Manager
1
0
Fork 0
Code Issues 3 Pull Requests Projects Releases Wiki Activity

Adding a "Deselect All" button #9

Merged
CRImier merged 3 commits from master into master 2020-08-25 01:45:47 +00:00
Conversation 11 Commits 3 Files Changed 3 +15 -1
CRImier commented 2020-04-13 17:10:13 +00:00 (Migrated from github.com)
Copy Link

Adding a "Deselect All" button so that you don't need to uncheck all other sessions in a multi-session environment every time you want to save three single-window session out of, say, 50 windows.

I have 88 windows open at the moment (with 1588 tabs), and I want to clean it up some by saving sessions until they're needed. Picked your extension because you seem active when it comes to development and responses to users, and decided I'd try developing the feature I currently need the most =) Tested this and it works for me, let me know if I need to make any changes.

Cheers!
Arsenijs

Adding a "Deselect All" button so that you don't need to uncheck all other sessions in a multi-session environment every time you want to save three single-window session out of, say, 50 windows. I have 88 windows open at the moment (with 1588 tabs), and I want to clean it up some by saving sessions until they're needed. Picked your extension because you seem active when it comes to development and responses to users, and decided I'd try developing the feature I currently need the most =) Tested this and it works for me, let me know if I need to make any changes. Cheers! Arsenijs
CRImier commented 2020-05-06 19:43:05 +00:00 (Migrated from github.com)
Copy Link

Hi! Any news on merging this? I'd really like this feature to be mainlined so that the extension can be autoupdated in the future without any problems, and so that other people can use this feature, too.

Hi! Any news on merging this? I'd really like this feature to be mainlined so that the extension can be autoupdated in the future without any problems, and so that other people can use this feature, too.
maximstewart commented 2020-08-24 23:31:52 +00:00 (Migrated from github.com)
Copy Link

@CRImier I apologies, I never got a notification for this PR. I'm reviewing the change.

@CRImier I apologies, I never got a notification for this PR. I'm reviewing the change.
maximstewart commented 2020-08-24 23:37:57 +00:00 (Migrated from github.com)
Copy Link

It looks like I added this type of feature already. I apologies again for the late reply. I'll be closing the request.

It looks like I added this type of feature already. I apologies again for the late reply. I'll be closing the request.
CRImier commented 2020-08-24 23:39:25 +00:00 (Migrated from github.com)
Copy Link

Hey! Thank you so much for your reply! Is this feature in the latest release? I can't find it. Currently using my custom version from GitHub with my changes. Cheers!

Hey! Thank you so much for your reply! Is this feature in the latest release? I can't find it. Currently using my custom version from GitHub with my changes. Cheers!
maximstewart commented 2020-08-24 23:45:00 +00:00 (Migrated from github.com)
Copy Link

It is in the latest release if I've read your changes correctly and what you were going for. You wanted a (de)select all togglable button/checkbox to save sessions differently. I've added that type of feature titled "Select All" with the default state as checked. But, you can uncheck it to deselect an entire window from being saved. The same exists for editing a session too.

It is in the latest release if I've read your changes correctly and what you were going for. You wanted a (de)select all togglable button/checkbox to save sessions differently. I've added that type of feature titled "Select All" with the default state as checked. But, you can uncheck it to deselect an entire window from being saved. The same exists for editing a session too.
CRImier commented 2020-08-25 00:04:09 +00:00 (Migrated from github.com)
Copy Link

I don't think we're talking about the same thing. I have 50 windows right now. If I want to save one window into a session, I need to deselect every single window but one of them every time I do "Save", and given the UI isn't actually usable enough for scrolling through windows one-by-one, it's hard. If I need to save 10 windows out of 50 and I need to deselect windows one-by-one, I need to click 445 times - with this button, I only need to click 10 times.

Here's how the button that I added looks, to clarify:

image

I don't think we're talking about the same thing. I have 50 windows right now. If I want to save one window into a session, I need to deselect every single window but one of them every time I do "Save", and given the UI isn't actually usable enough for scrolling through windows one-by-one, it's hard. If I need to save 10 windows out of 50 and I need to deselect windows one-by-one, I need to click **445** times - with this button, I only need to click 10 times. Here's how the button that I added looks, to clarify: ![image](https://user-images.githubusercontent.com/3173633/91108019-7700d600-e67f-11ea-9c5c-751ae328faf5.png)
CRImier commented 2020-08-25 00:05:19 +00:00 (Migrated from github.com)
Copy Link

Basically, the "Select all" checkbox only works on a single window. I have a lot of windows and the "Select all" checkbox is not enough because, while it's a step in the right direction, I still need to click it too many times.

Basically, the "Select all" checkbox only works on a single window. I have a lot of windows and the "Select all" checkbox is not enough because, while it's a step in the right direction, I still need to click it too many times.
maximstewart commented 2020-08-25 00:22:31 +00:00 (Migrated from github.com)
Copy Link

Ahhh, OK, I understand. Would you please edit this to work with the Edit page as well? I'll merge the request thereafter. I think you'll just need to add the same button to the Edit modal.

Ahhh, OK, I understand. Would you please edit this to work with the Edit page as well? I'll merge the request thereafter. I think you'll just need to add the same button to the Edit modal.
maximstewart (Migrated from github.com) reviewed 2020-08-25 00:38:31 +00:00
src/scripts/events.js
@ -66,7 +66,10 @@ document.addEventListener("click", (e) => {
hideModal("loadModal");
maximstewart (Migrated from github.com) commented 2020-08-25 00:35:53 +00:00
Copy Link

Please change from "var" to "let"

Please change from "var" to "let"
src/scripts/utils.js
maximstewart (Migrated from github.com) commented 2020-08-25 00:36:40 +00:00
Copy Link

Same as other request: "var" --> "let"

Same as other request: "var" --> "let"
CRImier commented 2020-08-25 00:46:19 +00:00 (Migrated from github.com)
Copy Link

Added, tested, seems to work. Let me know if there are any other problems. Cheers!

Added, tested, seems to work. Let me know if there are any other problems. Cheers!
maximstewart commented 2020-08-25 02:03:56 +00:00 (Migrated from github.com)
Copy Link

Plugin has been updated:

https://addons.mozilla.org/en-US/firefox/addon/easy-session-manager/
Plugin has been updated: https://addons.mozilla.org/en-US/firefox/addon/easy-session-manager/
CRImier commented 2020-08-25 07:13:00 +00:00 (Migrated from github.com)
Copy Link

Thank you!

Thank you!
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: itdominator/Easy-Session-Manager#9
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?