diff --git a/ChangeLog b/ChangeLog
index a3b2a0d2..5845897c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -28,6 +28,8 @@ terminator trunk:
LP#1518557)
* Change the scroll_on_output default to false (Egmont Koblinger,
LP#1392822)
+ * Added radio options to the Cursor colour to make it easier to
+ go back to the XOR'd foreground colour (Steve Boddy, LP#1512317)
Bug fixes
* Fix for those not running IBus, where the IBus workaround caused
diff --git a/terminatorlib/config.py b/terminatorlib/config.py
index 8c794f32..fc2603f1 100755
--- a/terminatorlib/config.py
+++ b/terminatorlib/config.py
@@ -215,7 +215,8 @@ DEFAULTS = {
'color_scheme' : 'grey_on_black',
'cursor_blink' : True,
'cursor_shape' : 'block',
- 'cursor_color' : '#aaaaaa',
+ 'cursor_color' : '',
+ 'cursor_color_fg' : True,
'emulation' : 'xterm',
'term' : 'xterm-256color',
'colorterm' : 'gnome-terminal',
diff --git a/terminatorlib/preferences.glade b/terminatorlib/preferences.glade
index 021c2920..62650cf3 100644
--- a/terminatorlib/preferences.glade
+++ b/terminatorlib/preferences.glade
@@ -1784,24 +1784,70 @@
diff --git a/terminatorlib/prefseditor.py b/terminatorlib/prefseditor.py
index 3b353092..72c2f216 100755
--- a/terminatorlib/prefseditor.py
+++ b/terminatorlib/prefseditor.py
@@ -448,13 +448,24 @@ class PrefsEditor:
# Cursor blink
widget = guiget('cursor_blink')
widget.set_active(self.config['cursor_blink'])
- # Cursor colour
+ # Cursor colour - Radio values
+ if self.config['cursor_color_fg']:
+ widget = guiget('cursor_color_foreground_radiobutton')
+ else:
+ widget = guiget('cursor_color_custom_radiobutton')
+ widget.set_active(True)
+ # Cursor colour - swatch
widget = guiget('cursor_color')
+ widget.set_sensitive(not self.config['cursor_color_fg'])
try:
- widget.set_color(gtk.gdk.Color(self.config['cursor_color']))
- except ValueError:
- self.config['cursor_color'] = "#FFFFFF"
- widget.set_color(gtk.gdk.Color(self.config['cursor_color']))
+ widget.set_color(gtk.gdk.Color(self.config['cursor_color']))
+ except (ValueError, TypeError):
+ try:
+ self.config['cursor_color'] = self.config['foreground_color']
+ widget.set_color(gtk.gdk.Color(self.config['cursor_color']))
+ except ValueError:
+ self.config['cursor_color'] = "#FFFFFF"
+ widget.set_color(gtk.gdk.Color(self.config['cursor_color']))
## Command tab
# Login shell
@@ -961,6 +972,26 @@ class PrefsEditor:
self.config['custom_command'] = widget.get_text()
self.config.save()
+ def on_cursor_color_type_toggled(self, widget):
+ guiget = self.builder.get_object
+
+ customwidget = guiget('cursor_color_custom_radiobutton')
+ colorwidget = guiget('cursor_color')
+
+ colorwidget.set_sensitive(customwidget.get_active())
+ self.config['cursor_color_fg'] = not customwidget.get_active()
+
+ try:
+ colorwidget.set_color(gtk.gdk.color_parse(self.config['cursor_color']))
+ except (ValueError, TypeError):
+ try:
+ self.config['cursor_color'] = self.config['foreground_color']
+ colorwidget.set_color(gtk.gdk.color_parse(self.config['cursor_color']))
+ except ValueError:
+ self.config['cursor_color'] = "#FFFFFF"
+ colorwidget.set_color(gtk.gdk.color_parse(self.config['cursor_color']))
+ self.config.save()
+
def on_cursor_color_color_set(self, widget):
"""Cursor colour changed"""
self.config['cursor_color'] = color2hex(widget)
diff --git a/terminatorlib/terminal.py b/terminatorlib/terminal.py
index 6dfbd6a2..46128706 100755
--- a/terminatorlib/terminal.py
+++ b/terminatorlib/terminal.py
@@ -799,7 +799,7 @@ class Terminal(gtk.VBox):
def set_cursor_color(self):
"""Set the cursor color appropriately"""
- if self.config['cursor_color'] == self.config['foreground_color']:
+ if self.config['cursor_color_fg']:
try:
self.vte.set_color_cursor(None)
except TypeError: