From 2ee2af68ddf548694f38f925ec379f9938221cc5 Mon Sep 17 00:00:00 2001
From: Arun Raghavan <arun@asymptotic.io>
Date: Fri, 24 May 2024 17:05:09 -0400
Subject: [PATCH] Fix translatable key in ui files

The value needs to be "yes" rather than "1" for the pot/po files to be
updated correctly.

Shoutout to Thomas Lange for reporting the issue and deducing the fix.

Fixes: https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/issues/156
---
 src/cardwidget.ui    |  8 ++++----
 src/channelwidget.ui |  4 ++--
 src/devicewidget.ui  | 32 ++++++++++++++++----------------
 src/mainwindow.ui    | 32 ++++++++++++++++----------------
 src/renamedialog.ui  |  6 +++---
 src/streamwidget.ui  |  8 ++++----
 6 files changed, 45 insertions(+), 45 deletions(-)

diff --git a/src/cardwidget.ui b/src/cardwidget.ui
index effd2e3..741dc61 100644
--- a/src/cardwidget.ui
+++ b/src/cardwidget.ui
@@ -27,7 +27,7 @@
                 <child>
                   <object class="GtkLabel" id="cardNameLabel">
                     <property name="hexpand">1</property>
-                    <property name="label" translatable="1">Card Name</property>
+                    <property name="label" translatable="yes">Card Name</property>
                     <property name="use_markup">1</property>
                     <property name="ellipsize">middle</property>
                     <property name="xalign">0</property>
@@ -42,7 +42,7 @@
                   <object class="GtkToggleButton" id="profileLockToggleButton">
                     <property name="halign">center</property>
                     <property name="focusable">1</property>
-                    <property name="tooltip_text" translatable="1">Lock card to this profile</property>
+                    <property name="tooltip_text" translatable="yes">Lock card to this profile</property>
                     <property name="has-frame">0</property>
                     <property name="active">1</property>
                     <child>
@@ -63,7 +63,7 @@
             <property name="spacing">6</property>
             <child>
               <object class="GtkLabel">
-                <property name="label" translatable="1">&lt;b&gt;Profile:&lt;/b&gt;</property>
+                <property name="label" translatable="yes">&lt;b&gt;Profile:&lt;/b&gt;</property>
                 <property name="use_markup">1</property>
                 <property name="xalign">0</property>
               </object>
@@ -79,7 +79,7 @@
                 <property name="spacing">6</property>
                 <child>
                   <object class="GtkLabel">
-                    <property name="label" translatable="1">&lt;b&gt;Codec:&lt;/b&gt;</property>
+                    <property name="label" translatable="yes">&lt;b&gt;Codec:&lt;/b&gt;</property>
                     <property name="use_markup">1</property>
                     <property name="xalign">0</property>
                   </object>
diff --git a/src/channelwidget.ui b/src/channelwidget.ui
index 66e6775..d8c8ace 100644
--- a/src/channelwidget.ui
+++ b/src/channelwidget.ui
@@ -6,7 +6,7 @@
     <child>
       <object class="GtkLabel" id="channelLabel">
         <property name="halign">center</property>
-        <property name="label" translatable="1">&lt;b&gt;left-front&lt;/b&gt;</property>
+        <property name="label" translatable="yes">&lt;b&gt;left-front&lt;/b&gt;</property>
         <property name="use_markup">1</property>
         <property name="xalign">1</property>
         <property name="yalign">0</property>
@@ -30,7 +30,7 @@
         <property name="halign">center</property>
         <property name="margin_start">8</property>
         <property name="margin_end">8</property>
-        <property name="label" translatable="1">&lt;small&gt;50%&lt;/small&gt;</property>
+        <property name="label" translatable="yes">&lt;small&gt;50%&lt;/small&gt;</property>
         <property name="use_markup">1</property>
         <property name="justify">right</property>
         <property name="width_chars">12</property>
diff --git a/src/devicewidget.ui b/src/devicewidget.ui
index 7d23b4c..be15c55 100644
--- a/src/devicewidget.ui
+++ b/src/devicewidget.ui
@@ -30,7 +30,7 @@
                 </child>
                 <child>
                   <object class="GtkLabel" id="deviceNameLabel">
-                    <property name="label" translatable="1">Device Title</property>
+                    <property name="label" translatable="yes">Device Title</property>
                     <property name="use_markup">1</property>
                     <property name="ellipsize">end</property>
                     <property name="xalign">0</property>
@@ -45,7 +45,7 @@
                   <object class="GtkToggleButton" id="deviceMuteToggleButton">
                     <property name="halign">center</property>
                     <property name="focusable">1</property>
-                    <property name="tooltip_text" translatable="1">Mute audio</property>
+                    <property name="tooltip_text" translatable="yes">Mute audio</property>
                     <property name="has-frame">0</property>
                     <child>
                       <object class="GtkImage">
@@ -59,7 +59,7 @@
                   <object class="GtkToggleButton" id="deviceLockToggleButton">
                     <property name="halign">center</property>
                     <property name="focusable">1</property>
-                    <property name="tooltip_text" translatable="1">Lock channels together</property>
+                    <property name="tooltip_text" translatable="yes">Lock channels together</property>
                     <property name="has-frame">0</property>
                     <property name="active">1</property>
                     <child>
@@ -74,7 +74,7 @@
                   <object class="GtkToggleButton" id="defaultToggleButton">
                     <property name="halign">center</property>
                     <property name="focusable">1</property>
-                    <property name="tooltip_text" translatable="1">Set as default</property>
+                    <property name="tooltip_text" translatable="yes">Set as default</property>
                     <child>
                       <object class="GtkImage">
                         <property name="icon_name">emblem-default</property>
@@ -92,7 +92,7 @@
             <property name="spacing">6</property>
             <child>
               <object class="GtkLabel">
-                <property name="label" translatable="1">&lt;b&gt;Port:&lt;/b&gt;</property>
+                <property name="label" translatable="yes">&lt;b&gt;Port:&lt;/b&gt;</property>
                 <property name="use_markup">1</property>
                 <property name="xalign">0</property>
               </object>
@@ -133,7 +133,7 @@
                     <property name="column_homogeneous">1</property>
                     <child>
                       <object class="GtkCheckButton" id="encodingFormatPCM">
-                        <property name="label" translatable="1">PCM</property>
+                        <property name="label" translatable="yes">PCM</property>
                         <property name="sensitive">0</property>
                         <property name="focusable">1</property>
                         <property name="active">1</property>
@@ -145,7 +145,7 @@
                     </child>
                     <child>
                       <object class="GtkCheckButton" id="encodingFormatAC3">
-                        <property name="label" translatable="1">AC-3</property>
+                        <property name="label" translatable="yes">AC-3</property>
                         <property name="focusable">1</property>
                         <layout>
                           <property name="column">1</property>
@@ -155,7 +155,7 @@
                     </child>
                     <child>
                       <object class="GtkCheckButton" id="encodingFormatDTS">
-                        <property name="label" translatable="1">DTS</property>
+                        <property name="label" translatable="yes">DTS</property>
                         <property name="focusable">1</property>
                         <layout>
                           <property name="column">2</property>
@@ -165,7 +165,7 @@
                     </child>
                     <child>
                       <object class="GtkCheckButton" id="encodingFormatEAC3">
-                        <property name="label" translatable="1">E-AC-3</property>
+                        <property name="label" translatable="yes">E-AC-3</property>
                         <property name="focusable">1</property>
                         <layout>
                           <property name="column">0</property>
@@ -175,7 +175,7 @@
                     </child>
                     <child>
                       <object class="GtkCheckButton" id="encodingFormatMPEG">
-                        <property name="label" translatable="1">MPEG</property>
+                        <property name="label" translatable="yes">MPEG</property>
                         <property name="focusable">1</property>
                         <layout>
                           <property name="column">1</property>
@@ -185,7 +185,7 @@
                     </child>
                     <child>
                       <object class="GtkCheckButton" id="encodingFormatAAC">
-                        <property name="label" translatable="1">AAC</property>
+                        <property name="label" translatable="yes">AAC</property>
                         <property name="focusable">1</property>
                         <layout>
                           <property name="column">2</property>
@@ -195,7 +195,7 @@
                     </child>
                     <child>
                       <object class="GtkCheckButton" id="encodingFormatTRUEHD">
-                        <property name="label" translatable="1">TrueHD</property>
+                        <property name="label" translatable="yes">TrueHD</property>
                         <property name="focusable">1</property>
                         <layout>
                           <property name="column">0</property>
@@ -205,7 +205,7 @@
                     </child>
                     <child>
                       <object class="GtkCheckButton" id="encodingFormatDTSHD">
-                        <property name="label" translatable="1">DTS-HD</property>
+                        <property name="label" translatable="yes">DTS-HD</property>
                         <property name="focusable">1</property>
                         <layout>
                           <property name="column">1</property>
@@ -221,7 +221,7 @@
                     <property name="spacing">6</property>
                     <child>
                       <object class="GtkLabel">
-                        <property name="label" translatable="1">&lt;b&gt;Latency offset:&lt;/b&gt;</property>
+                        <property name="label" translatable="yes">&lt;b&gt;Latency offset:&lt;/b&gt;</property>
                         <property name="use_markup">1</property>
                         <property name="xalign">0</property>
                       </object>
@@ -234,7 +234,7 @@
                     </child>
                     <child>
                       <object class="GtkLabel">
-                        <property name="label" translatable="1">ms</property>
+                        <property name="label" translatable="yes">ms</property>
                         <property name="use_markup">1</property>
                       </object>
                     </child>
@@ -244,7 +244,7 @@
             </child>
             <child type="label">
               <object class="GtkLabel" id="advancedLabel">
-                <property name="label" translatable="1">Advanced</property>
+                <property name="label" translatable="yes">Advanced</property>
               </object>
             </child>
           </object>
diff --git a/src/mainwindow.ui b/src/mainwindow.ui
index d6e92b7..057aef6 100644
--- a/src/mainwindow.ui
+++ b/src/mainwindow.ui
@@ -2,7 +2,7 @@
 <interface>
   <requires lib="gtk" version="4.0"/>
   <object class="GtkWindow" id="mainWindow">
-    <property name="title" translatable="1">Volume Control</property>
+    <property name="title" translatable="yes">Volume Control</property>
     <property name="default_width">500</property>
     <property name="default_height">400</property>
     <property name="icon_name">multimedia-volume-control</property>
@@ -37,7 +37,7 @@
                                   <object class="GtkLabel" id="noStreamsLabel">
                                     <property name="vexpand">1</property>
                                     <property name="sensitive">0</property>
-                                    <property name="label" translatable="1">&lt;i&gt;No application is currently playing audio.&lt;/i&gt;</property>
+                                    <property name="label" translatable="yes">&lt;i&gt;No application is currently playing audio.&lt;/i&gt;</property>
                                     <property name="use_markup">1</property>
                                   </object>
                                 </child>
@@ -63,7 +63,7 @@
                         <child>
                           <object class="GtkLabel">
                             <property name="hexpand">1</property>
-                            <property name="label" translatable="1">&lt;b&gt;_Show:&lt;/b&gt;</property>
+                            <property name="label" translatable="yes">&lt;b&gt;_Show:&lt;/b&gt;</property>
                             <property name="use_markup">1</property>
                             <property name="use_underline">1</property>
                             <property name="xalign">1</property>
@@ -104,7 +104,7 @@
                 </property>
                 <property name="tab">
                   <object class="GtkLabel">
-                    <property name="label" translatable="1">_Playback</property>
+                    <property name="label" translatable="yes">_Playback</property>
                     <property name="use_underline">1</property>
                   </object>
                 </property>
@@ -128,7 +128,7 @@
                                   <object class="GtkLabel" id="noRecsLabel">
                                     <property name="vexpand">1</property>
                                     <property name="sensitive">0</property>
-                                    <property name="label" translatable="1">&lt;i&gt;No application is currently recording audio.&lt;/i&gt;</property>
+                                    <property name="label" translatable="yes">&lt;i&gt;No application is currently recording audio.&lt;/i&gt;</property>
                                     <property name="use_markup">1</property>
                                   </object>
                                 </child>
@@ -154,7 +154,7 @@
                         <child>
                           <object class="GtkLabel">
                             <property name="hexpand">1</property>
-                            <property name="label" translatable="1">&lt;b&gt;_Show:&lt;/b&gt;</property>
+                            <property name="label" translatable="yes">&lt;b&gt;_Show:&lt;/b&gt;</property>
                             <property name="use_markup">1</property>
                             <property name="use_underline">1</property>
                             <property name="xalign">1</property>
@@ -195,7 +195,7 @@
                 </property>
                 <property name="tab">
                   <object class="GtkLabel">
-                    <property name="label" translatable="1">_Recording</property>
+                    <property name="label" translatable="yes">_Recording</property>
                     <property name="use_underline">1</property>
                   </object>
                 </property>
@@ -219,7 +219,7 @@
                                   <object class="GtkLabel" id="noSinksLabel">
                                     <property name="vexpand">1</property>
                                     <property name="sensitive">0</property>
-                                    <property name="label" translatable="1">&lt;i&gt;No output devices available&lt;/i&gt;</property>
+                                    <property name="label" translatable="yes">&lt;i&gt;No output devices available&lt;/i&gt;</property>
                                     <property name="use_markup">1</property>
                                   </object>
                                 </child>
@@ -245,7 +245,7 @@
                         <child>
                           <object class="GtkLabel">
                             <property name="hexpand">1</property>
-                            <property name="label" translatable="1">&lt;b&gt;S_how:&lt;/b&gt;</property>
+                            <property name="label" translatable="yes">&lt;b&gt;S_how:&lt;/b&gt;</property>
                             <property name="use_markup">1</property>
                             <property name="use_underline">1</property>
                             <property name="mnemonic_widget">sinkTypeComboBox</property>
@@ -287,7 +287,7 @@
                 </property>
                 <property name="tab">
                   <object class="GtkLabel">
-                    <property name="label" translatable="1">_Output Devices</property>
+                    <property name="label" translatable="yes">_Output Devices</property>
                     <property name="use_underline">1</property>
                   </object>
                 </property>
@@ -311,7 +311,7 @@
                                   <object class="GtkLabel" id="noSourcesLabel">
                                     <property name="vexpand">1</property>
                                     <property name="sensitive">0</property>
-                                    <property name="label" translatable="1">&lt;i&gt;No input devices available&lt;/i&gt;</property>
+                                    <property name="label" translatable="yes">&lt;i&gt;No input devices available&lt;/i&gt;</property>
                                     <property name="use_markup">1</property>
                                   </object>
                                 </child>
@@ -337,7 +337,7 @@
                         <child>
                           <object class="GtkLabel">
                             <property name="hexpand">1</property>
-                            <property name="label" translatable="1">&lt;b&gt;Sho_w:&lt;/b&gt;</property>
+                            <property name="label" translatable="yes">&lt;b&gt;Sho_w:&lt;/b&gt;</property>
                             <property name="use_markup">1</property>
                             <property name="use_underline">1</property>
                             <property name="mnemonic_widget">sourceTypeComboBox</property>
@@ -385,7 +385,7 @@
                 </property>
                 <property name="tab">
                   <object class="GtkLabel">
-                    <property name="label" translatable="1">_Input Devices</property>
+                    <property name="label" translatable="yes">_Input Devices</property>
                     <property name="use_underline">1</property>
                   </object>
                 </property>
@@ -413,7 +413,7 @@
                                       <object class="GtkLabel" id="noCardsLabel">
                                         <property name="vexpand">1</property>
                                         <property name="sensitive">0</property>
-                                        <property name="label" translatable="1">&lt;i&gt;No cards available for configuration&lt;/i&gt;</property>
+                                        <property name="label" translatable="yes">&lt;i&gt;No cards available for configuration&lt;/i&gt;</property>
                                         <property name="use_markup">1</property>
                                       </object>
                                     </child>
@@ -428,7 +428,7 @@
                                     </child>
                                     <child>
                                       <object class="GtkCheckButton" id="showVolumeMetersCheckButton">
-                                        <property name="label" translatable="1">Show volume meters</property>
+                                        <property name="label" translatable="yes">Show volume meters</property>
                                         <property name="focusable">1</property>
                                         <property name="active">1</property>
                                       </object>
@@ -445,7 +445,7 @@
                 </property>
                 <property name="tab">
                   <object class="GtkLabel">
-                    <property name="label" translatable="1">_Configuration</property>
+                    <property name="label" translatable="yes">_Configuration</property>
                     <property name="use_underline">1</property>
                   </object>
                 </property>
diff --git a/src/renamedialog.ui b/src/renamedialog.ui
index 9ee488a..0e7dbc4 100644
--- a/src/renamedialog.ui
+++ b/src/renamedialog.ui
@@ -13,7 +13,7 @@
         <child>
           <object class="GtkLabel">
             <property name="vexpand">1</property>
-            <property name="label" translatable="1">&lt;b&gt;Rename device to:&lt;/b&gt;</property>
+            <property name="label" translatable="yes">&lt;b&gt;Rename device to:&lt;/b&gt;</property>
             <property name="use_markup">1</property>
             <property name="xalign">0</property>
           </object>
@@ -34,7 +34,7 @@
             <property name="homogeneous">1</property>
             <child>
               <object class="GtkButton">
-                <property name="label" translatable="1">_Cancel</property>
+                <property name="label" translatable="yes">_Cancel</property>
                 <property name="use_underline">1</property>
                 <property name="focusable">1</property>
                 <property name="action_name">window.close</property>
@@ -42,7 +42,7 @@
             </child>
             <child>
               <object class="GtkButton" id="renameButton">
-                <property name="label" translatable="1">_Ok</property>
+                <property name="label" translatable="yes">_Ok</property>
                 <property name="use_underline">1</property>
                 <property name="focusable">1</property>
                 <property name="action_name">win.rename</property>
diff --git a/src/streamwidget.ui b/src/streamwidget.ui
index 023d760..2147a6b 100644
--- a/src/streamwidget.ui
+++ b/src/streamwidget.ui
@@ -31,7 +31,7 @@
                 </child>
                 <child>
                   <object class="GtkLabel" id="streamNameLabel">
-                    <property name="label" translatable="1">Stream Title</property>
+                    <property name="label" translatable="yes">Stream Title</property>
                     <property name="use_markup">1</property>
                     <property name="ellipsize">end</property>
                     <property name="xalign">0</property>
@@ -41,7 +41,7 @@
                   <object class="GtkLabel" id="directionLabel">
                     <property name="margin_start">4</property>
                     <property name="margin_end">4</property>
-                    <property name="label" translatable="1">direction</property>
+                    <property name="label" translatable="yes">direction</property>
                     <property name="use_markup">1</property>
                     <property name="xalign">0</property>
                   </object>
@@ -61,7 +61,7 @@
                   <object class="GtkToggleButton" id="streamMuteToggleButton">
                     <property name="halign">center</property>
                     <property name="focusable">1</property>
-                    <property name="tooltip_text" translatable="1">Mute audio</property>
+                    <property name="tooltip_text" translatable="yes">Mute audio</property>
                     <property name="has-frame">0</property>
                     <child>
                       <object class="GtkImage">
@@ -75,7 +75,7 @@
                   <object class="GtkToggleButton" id="streamLockToggleButton">
                     <property name="halign">center</property>
                     <property name="focusable">1</property>
-                    <property name="tooltip_text" translatable="1">Lock channels together</property>
+                    <property name="tooltip_text" translatable="yes">Lock channels together</property>
                     <property name="has-frame">0</property>
                     <property name="active">1</property>
                     <child>